Repository navigation
[ISSUE #12873]🐛Skip unused Broker send hook metadata scans - #12874
Merged
Merged
Conversation
Collaborator
|
🔊@mxsm 🚀Thanks for your contribution🎉! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes(Closes)
Brief Description
The default Broker walked every extension field a second time to collect account metadata even when its send hook list was empty. Capture the metadata only for registered hooks. Ordinary, batch and transactional sends retain their hook behavior and request correlation ID. Move the transaction ID and recall handle into the response.
How Did You Test This Change?
The original comparison from #12844 uses
391ed3e31and83da1b371. The isolated fix comparison uses11fd90459and the same revision with this change. The final row uses the historical baseline and the rebased PR head7494648e6, including the main branch update to bytes 1.12.2. The squash commitbeaf6ea7balso picked up the concurrent clap and clap_derive 4.6.8 lockfile update and passed the same 11 tests. Cycle measurements use the PR head as indicated in the table. The Rust PGO input was identical. Independently retraining BOLT on a single input executable changed the hot text. Reapplying the original profile reproduced the original text byte for byte.For the isolated release comparison, retired instructions per send changed from 186,741 to 184,328 (-1.29%). The primary statistic is the ratio of total Broker cycles per completed message. Intervals resample whole boot pairs. The diagnostic sampler groups counters per thread, differences raw counts and running times inside the client measurement window and cross-checks task time against process CPU time.
Enabling the original sampler increased client elapsed time per message by 7.49% on the same executable. Changing only its polling interval from 8 ms to 75 ms changed cycles per send by -0.46% across four repeated boots.
The earlier +21.2% came from two pairs. Those runs retained aggregate counters only. Their executable layouts and thread scheduling history are unavailable, so the specific cause of those two observations cannot be reconstructed. The unconditional hook scan was present on both historical revisions.
Paired cycle changes in execution order