Repository navigation
[ISSUE #11049]🐛Reuse verified evidence within the image release workflow - #11057
Merged
Merged
Conversation
Collaborator
|
🔊@mxsm 🚀Thanks for your contribution🎉! |
rocketmq-rust-bot
approved these changes
Oct 1, 2026
rocketmq-rust-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - Required CI checks passed ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes(Closes)
Brief Description
Re-running image publication downloaded every historical Cosign bundle for each unchanged digest, exhausting Docker Hub pull quotas and sometimes discovering an older SBOM before the current one. Verify each newly uploaded signature and attestation bundle directly with Cosign's digest-claim verification, release workflow certificate identity, issuer and transparency proofs. Keep source/component annotations, exact repository/digest binding, full SBOM equality and the existing image-verification JSON evidence view.
The automatic GHCR mirror downloads qualified Docker Hub artifacts from the same Actions run, independently re-verifies both signed bundles and checks the exact image subject and zero-CRITICAL scan before any copy. Missing, incomplete, conflicting, malformed or invalid evidence remains a failure. Independent GHCR dispatches retain registry verification and fresh scanning. Archive the original source bundles and bind all evidence hashes in the signed publication record.
How Did You Test This Change?
python -m unittest discover -s scripts/tests -p 'test_publish*.py': all 76 tests passed, covering exact digest/SBOM/source bindings, certificate verification failures, scan subject and CRITICAL rejection, incomplete evidence and publication boundaries.git diff --check: passed.