Skip to content

Exclude egld-000000 from tokens count response - #1624

Merged
stefangutica merged 3 commits into
developmentfrom
tokens-count-inconsistency
Aug 21, 2026
Merged

Exclude egld-000000 from tokens count response#1624
stefangutica merged 3 commits into
developmentfrom
tokens-count-inconsistency

Conversation

@stefangutica

@stefangutica stefangutica commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Reasoning

  • EGLD-000000 is a synthetic entry added manually to the tokens list (for multi-transfer support). It was filtered out only in getTokens, so GET /tokens/count returned a value 1 higher than the number of tokens actually listed by GET /tokens.

Proposed Changes

  • Moved the EGLD-000000 exclusion from getTokens into getFilteredTokens, so every consumer of the filtered list (list, count, tokens for address) sees the same set of tokens.

How to test

  • Compare GET /tokens/count with the number of items returned by GET /tokens?size=10000 — the values should match, and EGLD-000000 should not appear in the list.
  • Repeat with filters applied (e.g. ?type=FungibleESDT, ?search=...) and check that list and count stay consistent.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

k6 load testing comparison.
Base Commit Hash: 8d7e2e3
Target Commit Hash: b0444a8

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Mex26.63192.8035.8243.4132.46530.1744.0149.42+21.89% 🔴+174.98% 🔴+22.87% 🔴+13.85% 🔴
Nodes71.3712595.8352.85138.7732.45500.7243.9948.97-54.53% ✅-96.02% ✅-16.77% ✅-64.71% ✅
Pool26.57192.7435.7043.3432.31263.7444.0049.33+21.59% 🔴+36.83% 🔴+23.25% 🔴+13.83% 🔴
Tokens26.65254.7835.7643.8232.44468.6143.9648.82+21.70% 🔴+83.93% 🔴+22.95% 🔴+11.41% 🔴
Accounts152.04419.22244.20252.58149.17374.73274.05287.31-1.89% ✅-10.61% ✅+12.23% 🔴+13.75% 🔴
Blocks39.70665.3479.5997.1044.39799.7563.3972.30+11.82% 🔴+20.20% 🔴-20.36% ✅-25.54% ✅
Transactions76.2512571.9695.35113.5649.742937.4476.6688.75-34.76% ✅-76.63% ✅-19.60% ✅-21.85% ✅
Test Run Duration60001.8660002.10

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@stefangutica
stefangutica merged commit 8733370 into development Aug 21, 2026
12 of 18 checks passed
@stefangutica
stefangutica deleted the tokens-count-inconsistency branch August 21, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants