Fix collections sorting fallback - #1623
Merged
Merged
Conversation
|
k6 load testing comparison.
Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
claudiulataretu
approved these changes
Aug 20, 2026
popenta
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
verifiedAndHolderCount,api_isVerifiedandapi_holderCountare not present on every document in thetokensindex.searchAftercursor and returned an internal server error.0/1, so a missingapi_isVerifiedshould simply be treated asfalse, i.e.0.Proposed Changes
missing: 0to theapi_isVerifiedsort field, so collections without the flag sort as not verified.missing: 0to theapi_holderCountsort field, so collections without a holder count sort as zero holders.How to test
GET /collections?sort=verifiedAndHolderCount&size=25should return 200.searchAftercursor returned by the last item and confirm it works.