Repository navigation
Add option to hide device counts in table titles - #385
Open
Doomguy-BFG9000 wants to merge 2 commits into
Open
Doomguy-BFG9000 wants to merge 2 commits into
Doomguy-BFG9000 wants to merge 2 commits into
Conversation
Owner
|
Just a heads up, the man page is generated and shouldn't be manually updated. If you already used the generator for it, that's cool, but it's still good practice to leave the generated stuff untouched in PRs. |
Owner
|
The change as such looks fine to me, I'm just wondering if it's really worth adding a separate option for it. Maybe hiding the header altogether would make more sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--hide-device-countfor #277. It removes the leading count from table titles while preserving the default title and singular/plural wording. README and man-page source/output document the flag.Tests cover one and two mounts, both count settings, and ASCII/Unicode tables. Native executable checks exercised actual D: mount output with both styles and widths 40/100, plus JSON output with and without the flag.
Validation on Windows with Go 1.27.3:
go test -count=1 ./...,go vet ./...,go build, andgit diff --checkpassed. Linux/macOS runtime tests and the golangci-lint workflows were not run locally.Closes #277.