Add a test for argument assertion using maps - #1
Closed
mrnovalles wants to merge 2 commits into
Closed
mrnovalles wants to merge 2 commits into
mrnovalles wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using the
calledfunction withMaparguments I noticed that the matching was not exact, but that a map with different amount of key/values was still being mapped.This PR adds a test to make sure that this is no longer the case and that assertion of a called function where an argument is a map is always against the same exact map.
The meck counterpart PR is: eproxus/meck#244
Tests will not be green until this PR is merged and a meck version bump is made.