Skip to content

Always check if crypto.randomUUID is available in the getUuid helper (issue 22107) - #22108

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:issue-22107
Oct 8, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:issue-22107

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Don't skip this check in MOZCENTRAL builds, to prevent issues in non-"secure contexts" (i.e. HTTP).

…per (issue 22107)

Don't skip this check in MOZCENTRAL builds, to prevent issues in non-"secure contexts" (i.e. HTTP).
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 2f0b29b (run, references from mozilla/pdf.js.refs@05be816b55).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1382 11m 26s 0 0 0 0
Windows ✅ 1382 16m 27s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

Problems on Linux
TEST-UNEXPECTED-FAIL | test failed issue16114-partial | in firefox-1 | page1 round 1 | Optimized rendering differs from full rendering.
Problems on Windows
TEST-UNEXPECTED-FAIL | test failed issue16114-partial | in firefox-1 | page1 round 1 | Optimized rendering differs from full rendering.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.21%. Comparing base (5d923c9) to head (2f0b29b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22108      +/-   ##
==========================================
- Coverage   90.22%   90.21%   -0.01%     
==========================================
  Files         276      276              
  Lines       67811    67811              
==========================================
- Hits        61182    61179       -3     
- Misses       6629     6632       +3     
Flag Coverage Δ
browsertest 66.17% <0.00%> (-0.01%) ⬇️
fonttest 8.98% <0.00%> (ø)
integrationtest 69.29% <100.00%> (-0.01%) ⬇️
unittest 59.98% <100.00%> (+0.01%) ⬆️
unittestcli 58.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 8, 2026
@Snuffleupagus
Snuffleupagus merged commit dcb5136 into mozilla:master Oct 8, 2026
38 checks passed
@Snuffleupagus
Snuffleupagus deleted the issue-22107 branch October 8, 2026 20:43
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 8, 2026

This branch was successfully deployed

1 active deployment
sync_pdfs — 2f0b29b0 Deployed Oct 8, 2026 by Snuffleupagus via request #326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core regression release-blocker Blocker for the upcoming release

Projects

None yet

3 participants