Skip to content

Stop exporting the Font name by default - #22057

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:rm-name-export
Oct 3, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:rm-name-export

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

The only main-thread usage of this property is in the debuggers, hence we don't need to export it as part of the "compiled" font-info.

The only main-thread usage of this property is in the debuggers, hence we don't need to export it as part of the "compiled" font-info.
@codecov-commenter

codecov-commenter commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (ef62f31) to head (f8e53e0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22057      +/-   ##
==========================================
+ Coverage   90.35%   90.36%   +0.01%     
==========================================
  Files         269      269              
  Lines       67201    67199       -2     
==========================================
+ Hits        60720    60726       +6     
+ Misses       6481     6473       -8     
Flag Coverage Δ
browsertest 66.18% <100.00%> (+0.01%) ⬆️
fonttest 8.96% <100.00%> (ø)
integrationtest 69.38% <100.00%> (+<0.01%) ⬆️
unittest 59.60% <100.00%> (+<0.01%) ⬆️
unittestcli 58.11% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for f8e53e0 (run, references from mozilla/pdf.js.refs@567d5e933c).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1380 10m 26s 0 0 0 0
Windows ✅ 1380 14m 58s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 2, 2026
@timvandermeij
timvandermeij merged commit b5809f8 into mozilla:master Oct 3, 2026
23 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thanks!

@Snuffleupagus
Snuffleupagus deleted the rm-name-export branch October 3, 2026 12:07

This branch was successfully deployed

1 active deployment
sync_pdfs — f8e53e0e Deployed Oct 2, 2026 by Snuffleupagus via request #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants