Directly lookup entries in the cidToGidMap when building the charCodeToGlyphId map, for embedded composite fonts - #22056
Merged
timvandermeij merged 1 commit intoOct 2, 2026
Conversation
…odeToGlyphId` map, for embedded composite fonts Rather than first checking if the entry exists in the `cidToGidMap`, we can lookup it directly and instead fallback to `-1` when it doesn't exist.
Contributor
Reference testsResults for dc7ac33 (run, references from mozilla/pdf.js.refs@b22e6816e6).
The report is kept for 30 days and replaced by the next run. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22056 +/- ##
==========================================
+ Coverage 90.35% 90.37% +0.01%
==========================================
Files 269 269
Lines 67211 67207 -4
==========================================
+ Hits 60729 60736 +7
+ Misses 6482 6471 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 2, 2026
timvandermeij
approved these changes
Oct 2, 2026
Collaborator
|
Thank you for simplifying this! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than first checking if the entry exists in the
cidToGidMap, we can lookup it directly and instead fallback to-1when it doesn't exist.