Skip to content

Directly lookup entries in the cidToGidMap when building the charCodeToGlyphId map, for embedded composite fonts - #22056

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:charCodeToGlyphId-cidToGidMap-skip-has
Oct 2, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:charCodeToGlyphId-cidToGidMap-skip-has

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Rather than first checking if the entry exists in the cidToGidMap, we can lookup it directly and instead fallback to -1 when it doesn't exist.

…odeToGlyphId` map, for embedded composite fonts

Rather than first checking if the entry exists in the `cidToGidMap`, we can lookup it directly and instead fallback to `-1` when it doesn't exist.
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for dc7ac33 (run, references from mozilla/pdf.js.refs@b22e6816e6).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1380 11m 50s 0 0 0 0
Windows ✅ 1380 15m 1s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

@codecov-commenter

codecov-commenter commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (c33c32a) to head (dc7ac33).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22056      +/-   ##
==========================================
+ Coverage   90.35%   90.37%   +0.01%     
==========================================
  Files         269      269              
  Lines       67211    67207       -4     
==========================================
+ Hits        60729    60736       +7     
+ Misses       6482     6471      -11     
Flag Coverage Δ
browsertest 66.16% <100.00%> (-0.01%) ⬇️
fonttest 8.97% <0.00%> (+<0.01%) ⬆️
integrationtest 69.40% <100.00%> (+0.01%) ⬆️
unittest 59.57% <100.00%> (+<0.01%) ⬆️
unittestcli 58.08% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 2, 2026
@timvandermeij
timvandermeij merged commit 8496056 into mozilla:master Oct 2, 2026
23 of 24 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for simplifying this!

@Snuffleupagus
Snuffleupagus deleted the charCodeToGlyphId-cidToGidMap-skip-has branch October 2, 2026 14:08

This branch was successfully deployed

1 active deployment
sync_pdfs — dc7ac33f Deployed Oct 2, 2026 by Snuffleupagus via request #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants