Reject range requests made after ChunkedStreamManager.abort - #22052
Closed
charan-rathore wants to merge 1 commit into
Closed
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
Collaborator
|
This looks completely AI generated, and given the importance of this code there needs to be a reasonable expectation that there's a knowledgeable human actually involved here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22051
PDFDocumentLoadingTask.destroy()never resolved when it was called while a page was waiting for range data.Cause:
TerminateabortsChunkedStreamManager, and_requestChunksswallows the rejection once it is aborted.NetworkPdfManager.ensurethen retries, hitsMissingDataExceptionagain and callsrequestRange, which created a new request after the abort that nothing ever settled, so the termination never finished.Change (in
src/core/chunked_stream.js): range requests made afterChunkedStreamManager.abort()now reject right away with the abort reason, soensurestops retrying anddestroy()can finish. Two background requests are also skipped once aborted.Tests: 5 new unit specs in
test/unit/chunked_stream_spec.js(registered inclitests.jsonandjasmine-boot.js), including one that checksensurestops retrying after an abort. Without the fix that regression spec hangs.Verification (author's run, I did not re-run it):