Use the waitForTextToBe helper function in the editor undo bar integration tests - #21949
Merged
Merged
Conversation
…gration tests This reduces the amount of code needed for the checks, and thereby makes the intent of the assertions clearer. Note that, thanks to the FSI/PDI constants, we can now also compare the strings directly instead of having to do a manual replacement for the case where more than one annotation is removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21949 +/- ##
=======================================
Coverage 90.30% 90.31%
=======================================
Files 269 269
Lines 67546 67546
=======================================
+ Hits 61000 61004 +4
+ Misses 6546 6542 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the amount of code needed for the checks, and thereby makes the intent of the assertions clearer.
Note that, thanks to the FSI/PDI constants, we can now also compare the strings directly instead of having to do a manual replacement for the case where more than one annotation is removed.