Skip to content

Use grayscale text antialiasing in Windows Firefox tests - #21945

Open
calixteman wants to merge 1 commit into
mozilla:masterfrom
calixteman:grayscale-text-aa-windows
Open

calixteman wants to merge 1 commit into
mozilla:masterfrom
calixteman:grayscale-text-aa-windows

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Set the ClearType level to 0 and the rendering mode to natural symmetric (5). When Windows ClearType is enabled, Firefox applies these overrides and selects grayscale instead of subpixel antialiasing by default.

Set the ClearType level to 0 and the rendering mode to natural symmetric
(5). When Windows ClearType is enabled, Firefox applies these overrides
and selects grayscale instead of subpixel antialiasing by default.
@codecov-commenter

codecov-commenter commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (94b6d21) to head (19bd75d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21945      +/-   ##
==========================================
- Coverage   90.30%   90.30%   -0.01%     
==========================================
  Files         269      269              
  Lines       67544    67544              
==========================================
- Hits        60997    60994       -3     
- Misses       6547     6550       +3     
Flag Coverage Δ
browsertest 66.13% <ø> (-0.03%) ⬇️
fonttest 8.94% <ø> (ø)
integrationtest 69.34% <ø> (-0.01%) ⬇️
unittest 59.51% <ø> (+0.01%) ⬆️
unittestcli 57.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but it looks like the failing integration test can be relevant here as it compares pixel values for the Windows/Firefox combination, and thus might need changing. We should also run the reference tests on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants