Use platform print-to-PDF for FreeText appearances (bug 1794809) - #21858
Open
calixteman wants to merge 1 commit into
Open
Use platform print-to-PDF for FreeText appearances (bug 1794809)#21858calixteman wants to merge 1 commit into
calixteman wants to merge 1 commit into
Conversation
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 31, 2026 16:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21858 +/- ##
==========================================
- Coverage 90.26% 90.20% -0.07%
==========================================
Files 264 265 +1
Lines 67287 67414 +127
==========================================
+ Hits 60739 60809 +70
- Misses 6548 6605 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
calixteman
force-pushed
the
print_pdf_freetext
branch
from
September 2, 2026 16:37
f4c3e33 to
ffb5cc0
Compare
timvandermeij
approved these changes
Sep 6, 2026
PDF.js creates FreeText appearances with Helvetica and WinAnsiEncoding. It cannot generate a matching appearance when Helvetica cannot encode the text. Add a Firefox-only `printToPDF` callback to `saveDocument`. The worker batches serialized FreeText entries and imports one generated PDF page per appearance. The single-PDF batch preserves resources shared across pages. Copy each page's resources and content without reserializing retained operators. Drop marked-content operators because their metadata belongs to the generated PDF.
calixteman
force-pushed
the
print_pdf_freetext
branch
from
September 6, 2026 19:30
ffb5cc0 to
c3c21fa
Compare
Contributor
Author
|
/botio browsertest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7717739676a8b52/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/058aff0e55f02cc/output.txt |
Collaborator
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7717739676a8b52/output.txt Total script time: 19.04 mins
|
Collaborator
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/058aff0e55f02cc/output.txt Total script time: 24.20 mins
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDF.js creates FreeText appearances with Helvetica and WinAnsiEncoding. It cannot generate a matching appearance when Helvetica cannot encode the text.
Add a Firefox-only
printToPDFcallback tosaveDocument. The worker batches serialized FreeText entries and imports one generated PDF page per appearance. The single-PDF batch preserves resources shared across pages.Copy each page's resources and content without reserializing retained operators. Drop marked-content operators because their metadata belongs to the generated PDF.