Skip to content

Schedule render animation frames on the canvas's own window #21825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsg2021 wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −2
Open

Schedule render animation frames on the canvas's own window #21825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/display/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3342,6 +3342,25 @@ class InternalRenderTask {

static #canvasInUse = new WeakSet();

/**
* The window that owns the canvas being rendered into, falling back to the
* global one.
*
* These are not always the same window. A canvas can live in another
* document -- one opened with `window.open`, or an iframe -- while the code
* driving the render runs in the opener. Animation frames have to be
* scheduled on the window that owns the canvas: browsers pause
* `requestAnimationFrame` for a window that is not visible, so scheduling on
* an occluded opener means the callback never runs and the render stalls
* partway through, leaving a partially drawn canvas.
*/
get #ownerWindow() {
return (
(this._canvas ?? this._canvasContext?.canvas)?.ownerDocument
?.defaultView ?? window
);
}

constructor({
callback,
params,
Expand Down Expand Up @@ -3464,7 +3483,7 @@ class InternalRenderTask {
this.cancelled = true;
this.gfx?.endDrawing();
if (this.#rAF) {
window.cancelAnimationFrame(this.#rAF);
this.#ownerWindow.cancelAnimationFrame(this.#rAF);
this.#rAF = null;
}
InternalRenderTask.#canvasInUse.delete(this._canvas);
Expand Down Expand Up @@ -3508,7 +3527,7 @@ class InternalRenderTask {

_scheduleNext() {
if (this._useRequestAnimationFrame) {
this.#rAF = window.requestAnimationFrame(() => {
this.#rAF = this.#ownerWindow.requestAnimationFrame(() => {
this.#rAF = null;
this._nextBound().catch(this._cancelBound);
});
Expand Down