Repository navigation
Add a 'supportsDownloading' browser option to gate saving/downloading - #21310
Merged
Merged
Conversation
calixteman
had a problem deploying
to
code-coverage
May 20, 2026 17:55 — with 
GitHub Actions
Failure
GitHub Actions
Failure
calixteman
had a problem deploying
to
code-coverage
May 20, 2026 17:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
calixteman
had a problem deploying
to
code-coverage
May 20, 2026 17:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
calixteman
had a problem deploying
to
code-coverage
May 20, 2026 17:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21310 +/- ##
==========================================
- Coverage 89.80% 89.79% -0.01%
==========================================
Files 260 260
Lines 66058 66078 +20
==========================================
+ Hits 59321 59333 +12
- Misses 6737 6745 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
calixteman
had a problem deploying
to
code-coverage
May 21, 2026 07:10 — with
GitHub Actions
Failure
GitHub Actions
Failure
calixteman
had a problem deploying
to
code-coverage
May 21, 2026 07:10 — with
GitHub Actions
Failure
GitHub Actions
Failure
timvandermeij
approved these changes
May 21, 2026
timvandermeij
left a comment
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, with one comment. Thank you for implementing this!
Introduces a 'supportsDownloading' browser option (defaulting to false)
that lets embedders disable the save/download paths entirely. When
disabled:
- the toolbar and secondary-toolbar download buttons are hidden;
- PDFViewerApplication.{download,save,downloadOrSave} and the
"beforeunload" save prompt bail out early;
- the BaseDownloadManager helpers (download, downloadData,
openOrDownloadData) and the Firefox/generic _triggerDownload
implementations no-op.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a 'supportsDownloading' browser option (defaulting to false) that lets embedders disable the save/download paths entirely. When disabled: