Skip to content

Don't use "internal" EventBus methods in the integration-tests - #21305

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:integration-test-EventBus-on
May 21, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:integration-test-EventBus-on

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

This way guarantees that any and all internal viewer state has been updated first, before any test-specific code runs.

This way *guarantees* that any and all internal viewer state has been updated first, before any test-specific code runs.
@codecov-commenter

codecov-commenter commented May 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.90%. Comparing base (b13ec1f) to head (abe8b56).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21305      +/-   ##
==========================================
- Coverage   81.27%   79.90%   -1.38%     
==========================================
  Files         256      256              
  Lines       64873    66374    +1501     
==========================================
+ Hits        52728    53036     +308     
- Misses      12145    13338    +1193     
Flag Coverage Δ
integrationtest 66.91% <ø> (+0.13%) ⬆️
unittestcli 56.07% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 42db304 into mozilla:master May 21, 2026
14 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Good idea; thanks!

@Snuffleupagus
Snuffleupagus deleted the integration-test-EventBus-on branch May 21, 2026 18:57

This branch was previously deployed

1 inactive deployment
code-coverage — abe8b564 Deployed May 20, 2026 by Snuffleupagus via Test (26) #15684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants