Repository navigation
Don't use "internal" EventBus methods in the integration-tests - #21305
Merged
timvandermeij merged 1 commit intoMay 21, 2026
Merged
Conversation
This way *guarantees* that any and all internal viewer state has been updated first, before any test-specific code runs.
Snuffleupagus
temporarily deployed
to
code-coverage
May 20, 2026 14:44 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
May 20, 2026 14:44 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
May 20, 2026 14:44 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
May 20, 2026 14:44 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
May 20, 2026 14:44 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
May 20, 2026 14:44 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
May 20, 2026 14:44 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21305 +/- ##
==========================================
- Coverage 81.27% 79.90% -1.38%
==========================================
Files 256 256
Lines 64873 66374 +1501
==========================================
+ Hits 52728 53036 +308
- Misses 12145 13338 +1193
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
May 21, 2026
Collaborator
|
Good idea; thanks! |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way guarantees that any and all internal viewer state has been updated first, before any test-specific code runs.