Repository navigation
Sanitize glyf composite cycles, OS/2 length and maxp version mismatches - #21300
Conversation
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/e65634773e05224/output.txt |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21300 +/- ##
==========================================
+ Coverage 81.28% 81.40% +0.11%
==========================================
Files 256 256
Lines 64873 65328 +455
==========================================
+ Hits 52730 53178 +448
- Misses 12143 12150 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e65634773e05224/output.txt Total script time: 8.69 mins
Image differences available at: http://54.241.84.105:8877/e65634773e05224/reftest-analyzer.html#web=eq.log |
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6a7ddb72a828900/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6a7ddb72a828900/output.txt Total script time: 6.78 mins
Image differences available at: http://54.241.84.105:8877/6a7ddb72a828900/reftest-analyzer.html#web=eq.log |
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/684461b27fc9610/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/684461b27fc9610/output.txt Total script time: 18.45 mins
Image differences available at: http://54.241.84.105:8877/684461b27fc9610/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/09b36f0b4e2924e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/09b36f0b4e2924e/output.txt Total script time: 18.29 mins
Image differences available at: http://54.241.84.105:8877/09b36f0b4e2924e/reftest-analyzer.html#web=eq.log |
|
The "regression" is an improvement. |
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
Looks good to me, with the comment addressed; thank you!
Prune the back-edge components from cyclic composite glyphs in sanitizeGlyphLocations (leaving non-cyclic siblings intact), reject OS/2 tables whose length is too short for the declared version so a clean table gets regenerated, and upgrade a version 0.5 maxp table to 1.0 for TrueType fonts to silence OTS' "wrong maxp version for glyph data". It fixes mozilla#21298.
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5a20822a3060704/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5a20822a3060704/output.txt Total script time: 18.21 mins
Image differences available at: http://54.241.84.105:8877/5a20822a3060704/reftest-analyzer.html#web=eq.log |
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/dffb40dc787453b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/dffb40dc787453b/output.txt Total script time: 18.25 mins
|
Prune the back-edge components from cyclic composite glyphs in sanitizeGlyphLocations (leaving non-cyclic siblings intact), reject OS/2 tables whose length is too short for the declared version so a clean table gets regenerated, and upgrade a version 0.5 maxp table to 1.0 for TrueType fonts to silence OTS' "wrong maxp version for glyph data".
It fixes #21298.