Skip to content

chore(deps): bump joi from 17.13.8 to 17.13.9 - #21667

Merged
mozilla-blender[bot] merged 2 commits into
mainfrom
dependabot/npm_and_yarn/joi-17.13.9
Nov 3, 2026
Merged

mozilla-blender[bot] merged 2 commits into
mainfrom
dependabot/npm_and_yarn/joi-17.13.9

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Bumps joi from 17.13.8 to 17.13.9.

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file maintenance labels Nov 2, 2026
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: mozilla/fxa
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 387469d
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 68650bb8-3c6f-436f-aad6-9cc1ceac9bc4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@mozilla-blender

Copy link
Copy Markdown
Contributor

BLEnder investigated: This dependency has an open security alert, but the repo is not affected.

joi 17.13.8 is installed, but no code in the repo calls string().email({ multiple: true }), the only vulnerable path. Every .email() call uses literal options without multiple. Bump to 17.13.9 anyway.

This PR can be reviewed and merged as a normal dependency update.

@mozilla-blender

Copy link
Copy Markdown
Contributor

Note: This PR has failing CircleCI checks.
BLEnder cannot access CircleCI log output, so it
may not be able to diagnose or fix the failure.
Consider migrating CI to GitHub Actions so BLEnder
can read failure logs directly.

@mozilla-blender

Copy link
Copy Markdown
Contributor

BLEnder picked up this PR. Workflow run

@mozilla-blender

Copy link
Copy Markdown
Contributor

BLEnder could not fix this PR automatically. Workflow run

I couldn't reproduce either failure, so I haven't changed anything and haven't written .blender-commit-msg.

Why I couldn't reproduce it:

  • There are no CircleCI logs for either check.
  • I couldn't install the new joi 17.13.9. The sandbox blocked access to the package registry (registry.yarnpkg.com and registry.npmjs.org), so yarn install stopped at the download step and I couldn't run any tests.

What the lockfile shows:

  • The dependency resolution step of yarn install --immutable passed, so yarn.lock matches the package.json changes. That rules out lockfile drift.
  • After this bump there are two copies of joi: 17.13.9 for the five packages that were bumped, and 17.13.8 for anything that asks for 17.x.x or ^17.3.0.

A joi patch release is unlikely to break the Playwright functional tests. Those tests also sit behind a manual approval step, so the failure may be unrelated or flaky. test_pull_request is probably just the CircleCI workflow status, failing because the Playwright job failed. That's a guess, though, not a confirmed root cause.

Next steps: a re-run of the Playwright job, or its log output, would show whether this bump is actually the cause.

Bumps [joi](https://github.com/hapijs/joi) from 17.13.8 to 17.13.9.
- [Commits](hapijs/joi@v17.13.8...v17.13.9)

---
updated-dependencies:
- dependency-name: joi
  dependency-version: 17.13.9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/joi-17.13.9 branch from d858ec4 to 4f6f693 Compare November 2, 2026 18:07
Because:

- celebrate kept a nested joi 17.13.8, and the content server crashed at startup with "Cannot mix different versions of joi schemas"

This commit:

- dedupes joi in yarn.lock to a single 17.13.9

@mozilla-blender mozilla-blender Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLEnder auto-merge: all safety gates passed (CI green, patch/minor, compat 89%, no advisories).

@mozilla-blender
mozilla-blender Bot merged commit a71babb into main Nov 3, 2026
21 checks passed
@mozilla-blender
mozilla-blender Bot deleted the dependabot/npm_and_yarn/joi-17.13.9 branch November 3, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant