Skip to content

test(auth): drop the Monitor case from the fallback-service spec - #21645

Closed
nshirley wants to merge 1 commit into
mainfrom
fxa-14724-fallback-spec
Closed

nshirley wants to merge 1 commit into
mainfrom
fxa-14724-fallback-spec

Conversation

@nshirley

Copy link
Copy Markdown
Contributor

Because

This pull request

  • Removes the Monitor row from the spec. The vpn rows cover a configured service and the zero-id row covers an unknown one, so coverage of the rule is unchanged.

Issue that this pull request solves

Related: FXA-14724

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

Other information (Optional)

Will be cherry-picked to train-348 for v1.348.5 once merged.

Because:
- The case asserts the shipped default resolves 802d56ef2a9af9fa to
  monitor, which only holds once monitor is in serviceScopes (FXA-14723).
- Cherry-picking FXA-14724 onto a train without FXA-14723 fails the
  unit test (v1.348.4).

This commit:
- Removes the Monitor row; the vpn rows cover a configured service and
  the zero-id row covers an unknown one.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@nshirley

Copy link
Copy Markdown
Contributor Author

Closing; this was only a bug on the release branch because of a missed commit to cherry-pick for dot release

@nshirley nshirley closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant