Repository navigation
Conversation
Because: - The case asserts the shipped default resolves 802d56ef2a9af9fa to monitor, which only holds once monitor is in serviceScopes (FXA-14723). - Cherry-picking FXA-14724 onto a train without FXA-14723 fails the unit test (v1.348.4). This commit: - Removes the Monitor row; the vpn rows cover a configured service and the zero-id row covers an unknown one.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
Contributor
Author
|
Closing; this was only a bug on the release branch because of a missed commit to cherry-pick for dot release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
getFallbackServiceForClientspec asserts the shipped default maps802d56ef2a9af9fatomonitor. That only holds oncemonitoris inserviceScopes, which landed in FXA-14723.train-348, which predates FXA-14723, fails the Unit Test job onv1.348.4.This pull request
Issue that this pull request solves
Related: FXA-14724
Checklist
Other information (Optional)
Will be cherry-picked to
train-348forv1.348.5once merged.