Conversation
Because: - If a browser signals it supports pairing.version 1, we should not show a pairing v2 flow This Commit: - Fixes the logic in v2 gate to respect the firefox desktop pref, identity.fxaccounts.pairing.version
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The v=2 route can bypass the new browser capability gate.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates pairing v2 gating to respect the browser’s reported pairing capability.
Changes:
- Require pairing version 2 for v2 flows.
- Update unit and page-level tests.
- Refresh configuration and launcher documentation.
- Critical issue: the user-controlled
v=2route can still bypass the capability gate.
| File | Description |
|---|---|
packages/fxa-settings/src/pages/Pair/Index/index.test.tsx |
Tests v1/v2 pairing behavior. |
packages/fxa-settings/src/pages/ConnectAnotherDevice/index.test.tsx |
Tests authority routing decisions. |
packages/fxa-settings/src/lib/pairing/v2-gate.ts |
Enforces browser pairing capability. |
packages/fxa-settings/src/lib/pairing/v2-gate.test.ts |
Tests capability and version gating. |
packages/fxa-settings/src/lib/config.ts |
Updates pairing configuration documentation. |
packages/fxa-dev-launcher/README.md |
Documents local pairing requirements. |
packages/fxa-content-server/server/lib/configuration.js |
Updates configuration descriptions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Verification: fixedStack with
Recording, before: video.mp4Recording, after: video.mp4 |
vbudhram
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-14629
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.