Conversation
## Because - The `/mfa/test` and `/mfa/test2` routes were scaffolding from when we built the MFA auth strategy. They have no remaining callers. - The `test` MFA action existed only for those routes. ## This pull request - Removes `GET /mfa/test`, `POST /mfa/test` and `POST /mfa/test2` from `lib/routes/mfa.ts` in `fxa-auth-server`. - Removes `test` from the default `mfa.actions` in the auth-server config. - Removes `mfaTestGet`, `mfaTestPost` and `mfaTestPost2` from `fxa-auth-client`. This is a breaking change for those three methods only. - Removes the `test` action from the config override in `mfa_totp.in.spec.ts`. - Deletes `functional-tests/tests/misc/mfa.spec.ts`, which only drove the removed routes. ## Issue that this pull request solves Closes: https://mozilla-hub.atlassian.net/browse/FXA-14622
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Removes obsolete MFA scaffolding routes, configuration, client methods, and functional tests.
Changes:
- Deletes
/mfa/testand/mfa/test2. - Removes the
testMFA action and client methods. - Deletes obsolete functional-test coverage.
| File | Description |
|---|---|
packages/fxa-auth-server/test/remote/mfa_totp.in.spec.ts |
Updates MFA configuration |
packages/fxa-auth-server/lib/routes/mfa.ts |
Removes scaffolding routes |
packages/fxa-auth-server/config/index.ts |
Removes the default test action |
packages/fxa-auth-client/lib/client.ts |
Removes obsolete client methods |
packages/functional-tests/tests/misc/mfa.spec.ts |
Deletes obsolete route tests |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
clouserw
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
/mfa/testand/mfa/test2routes were scaffolding from when we built the MFA auth strategy. They have no remaining callers.testMFA action existed only for those routes.This pull request
GET /mfa/test,POST /mfa/testandPOST /mfa/test2fromlib/routes/mfa.tsinfxa-auth-server.testfrom the defaultmfa.actionsin the auth-server config.mfaTestGet,mfaTestPostandmfaTestPost2fromfxa-auth-client. This is a breaking change for those three methods only.testaction from the config override inmfa_totp.in.spec.ts.functional-tests/tests/misc/mfa.spec.ts, which only drove the removed routes.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-14622
Checklist
Put an
xin the boxes that applyHow to review (Optional)
packages/fxa-auth-server/lib/routes/mfa.ts,packages/fxa-auth-server/config/index.tsMFA__ACTIONSstill overrides the new default.Screenshots (Optional)
Other information (Optional)
lib/routes/mfa.spec.tsand the functional specspasskeyWrapApi.spec.tsandchangePasswordAfterPrimaryEmailSwap.spec.ts.config/index.spec.ts,lib/routes/mfa.spec.ts,lib/routes/auth-schemes/mfa.spec.tsandlib/routes/passkeys.spec.ts: 173 passed, 0 failed.nx lintpasses for the three changed packages.fxa-settingsstill lists atestMFA scope insrc/lib/types.ts, which theMfaGuardstories and tests use.