feat(settings): serve /subscriptions redirects from React by vbudhram · Pull Request #21295 · mozilla/fxa

vbudhram · 2026-09-23T21:00:41Z

Because

/subscriptions still runs in Backbone, so it blocks the move of post-verify routes to React.
The earlier plan kept this route in Backbone until FXA-6117. This PR moves it now instead, behind the staged rollout flag.

This pull request

Adds a SubscriptionsRedirect page in fxa-settings for /subscriptions.
Keeps parity with Backbone: usePaymentsNextSubscriptionManagement picks subscriptions/landing.
Serves the route from React through postVerifyOtherRoutes in the content-server react-app routes, with fullProdRollout: false.
Passes the subscriptions config from content-server to fxa-settings.

Issue that this pull request solves

Closes: FXA-6661

Checklist

Put an x in the boxes that apply

My commit is GPG signed.
If applicable, I have modified or added tests which pass locally.
I have added necessary documentation (if appropriate).
I have verified that my changes render correctly in RTL (if appropriate).
I have manually reviewed all AI generated code.

How to review (Optional)

Key files/areas to focus on: getSubscriptionsRedirect in SubscriptionsRedirect/index.tsx.
Suggested review order: the react-app routes, then App/index.tsx, then the page and its tests.
Risky or complex parts: the choice between the legacy management URL and the payments-next landing URL.

Screenshots (Optional)

Other information (Optional)

fullProdRollout: false stays. A reviewer asked to change it, but the epic rolls these routes out in stages.
SubscriptionsRedirect unit tests: 7 passed, 0 failed. eslint on the changed files and tsc --noEmit on fxa-settings exit 0.
I did not run functional tests. The operator validates the flows manually.
/subscriptions/products/:productId is out of scope because it has no users. The Backbone route and view for it stay for now.

Copilot

Copilot review overview

🟡 Changes recommended

Three moderate redirect correctness and privacy issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

Preserve literal plus signs in forwarded redirect parameters · New

What changed in this PR

Moves subscription redirects from Backbone into the feature-gated React settings app while preserving payment routing and authentication behavior.

Changes:

Adds the SubscriptionsRedirect page and tests.
Registers gated subscription routes.
Exposes subscription configuration to settings.

Required changes:

Use the app’s resolved metricsEnabled value to avoid forwarding flow identifiers when metrics preferences are unknown.
Preserve literal + characters when forwarding query parameters.
Detect ?signin= by parameter presence rather than its value.

File	Description
`packages/fxa-settings/src/pages/SubscriptionsRedirect/index.tsx`	Implements subscription redirect and token logic.
`packages/fxa-settings/src/pages/SubscriptionsRedirect/index.test.tsx`	Tests redirect and authentication scenarios.
`packages/fxa-settings/src/lib/config.ts`	Defines subscription configuration.
`packages/fxa-settings/src/components/App/index.tsx`	Registers subscription routes.
`packages/fxa-content-server/server/lib/routes/react-app/index.js`	Adds routes to the rollout group.
`packages/fxa-content-server/server/lib/beta-settings.js`	Exposes subscription settings.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

Six moderate issues remain in rollout routing, authentication, token issuance, metrics propagation, and query preservation.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2

Open (2)

Post-verification routes remain on Backbone without full rollout · New
Bare signin query flag is treated as false · New

Resolved since last review (1)

Preserve literal plus signs in forwarded redirect parameters

+      routes: reactRoute.getRoutes([
+        'subscriptions',
+        'subscriptions/products/[\\w_]+',
+      ]),


Copilot

Copilot review overview

🟡 Changes recommended

Unresolved moderate issues affect rollout, telemetry opt-out behavior, and duplicate redirect execution.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2

Open (2)

Guard redirect effect against duplicate StrictMode execution · New
Post-verification routes remain on Backbone without full rollout

Resolved since last review (1)

Bare signin query flag is treated as false

vbudhram · 2026-09-23T21:53:37Z

The ai-fixme pipeline used both review rounds on this PR, so it stops here. One review comment is still open: guard the redirect effect with a ref so that StrictMode does not request two OAuth tokens in development. A human needs to decide on that fix and review the PR.

Copilot

Copilot review overview

🟡 Changes recommended

Product redirects and staged client-side handoff are incomplete, while the redirect effect can issue duplicate OAuth tokens.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 6

Open (6)

Post-auth handoff remains incomplete for eligible routes · New
Product subscription URLs bypass the React route group · New
Missing React route for subscription product management URLs · New
Subscription redirect builder ignores product and RP parameters · New
Guard redirect effect against duplicate StrictMode execution
Post-verification routes remain on Backbone without full rollout

  brandMessagingMode: config.get('brandMessagingMode'),
  glean: { ...config.get('glean'), appDisplayVersion: config.get('version') },
  redirectAllowlist: config.get('redirect_check.allow_list'),
+  subscriptions: config.get('subscriptions'),


    postVerifyOtherRoutes: {
      featureFlagOn: showReactApp.postVerifyOtherRoutes,
-      routes: [],
+      routes: reactRoute.getRoutes(['subscriptions']),


+          path="/subscriptions"
+          element={<SubscriptionsRedirect {...{ isSignedIn }} />}


+  const base = usePaymentsNextSubscriptionManagement
+    ? `${config.servers.paymentsNext.url}/subscriptions/landing`
+    : `${managementUrl}/subscriptions`;
+  const query = params.toString();
+  const url = `${base}${query ? `?${query}` : ''}`;


Copilot

Copilot review overview

🟡 Changes recommended

The Backbone router and frontend rollout configuration do not yet hand enrolled users to the React route.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 6

Open (6)

Enable staged rollout for the subscriptions route · New
Subscription redirect builder ignores product and RP parameters
Missing React route for subscription product management URLs
Product subscription URLs bypass the React route group
Post-auth handoff remains incomplete for eligible routes
Post-verification routes remain on Backbone without full rollout

Resolved since last review (1)

Guard redirect effect against duplicate StrictMode execution

    postVerifyOtherRoutes: {
      featureFlagOn: showReactApp.postVerifyOtherRoutes,
-      routes: [],
+      routes: reactRoute.getRoutes(['subscriptions']),


StaberindeZA · 2026-09-25T17:06:07Z

+  flow: MetricsFlow | null;
+  metricsEnabled: boolean;
+}) {
+  const { managementUrl, usePaymentsNextSubscriptionManagement } =


suggestion: remove usePaymentsNextSubscriptionManagement flag and managementUrl.

This boolean was added as part of the SP3 cutover. All traffic now goes to the SP3 sub manage page, so this feature flag can be removed.

StaberindeZA · 2026-09-25T17:11:09Z

+  useEffect(() => {
+    if (redirected.current) {
+      return;
+    }
+    redirected.current = true;
+    const { url, unauthenticatedUrl } = getSubscriptionsRedirect({
+      config,
+      flow: getMetricsFlow(),
+      metricsEnabled: currentAccount()?.metricsEnabled !== false,
+    });
+
+    if (!isSignedIn) {
+      hardNavigate(unauthenticatedUrl);
+      return;
+    }
+
+    const { managementClientId, managementScopes, managementTokenTTL } =
+      config.subscriptions;
+    authClient
+      .createOAuthToken(sessionToken()!, managementClientId, {
+        scope: managementScopes,
+        ttl: managementTokenTTL,
+      })
+      .then(({ access_token }) =>
+        hardNavigate(`${url}#accessToken=${encodeURIComponent(access_token)}`)
+      )
+      .catch(() => hardNavigate(unauthenticatedUrl));
+  }, [authClient, config, isSignedIn]);


suggestion: remove this logic and just redirect to {payments-next}/subscriptions/landing

Much of this logic has been refactored and moved to payments-next and should no longer be the responsibility of content-server.

## Because - `/subscriptions` still runs in Backbone, so it blocks the move of post-verify routes to React. - The earlier plan kept this route in Backbone until FXA-6117. This PR moves it now instead, behind the staged rollout flag. ## This pull request - Adds a `SubscriptionsRedirect` page in fxa-settings that sends `/subscriptions` to payments-next `subscriptions/landing`, with flow params. - Serves the route from React through `postVerifyOtherRoutes`, with `fullProdRollout: false`. - Hands Backbone `/subscriptions` navigations to React with `createReactOrBackboneViewHandler`. ## Issue that this pull request solves Closes: FXA-6661

Copilot

Copilot review overview

🟡 Changes recommended

The React redirect ignores the subscription-management rollout flag and always sends users to Payments Next.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 6

Open (7)

Honor rollout flag for subscription management destination · New
Enable staged rollout for the subscriptions route
Subscription redirect builder ignores product and RP parameters
Missing React route for subscription product management URLs
Product subscription URLs bypass the React route group
Post-auth handoff remains incomplete for eligible routes
Post-verification routes remain on Backbone without full rollout

+      getSubscriptionsRedirect({
+        paymentsNextUrl: config.servers.paymentsNext.url,
+        flow: getMetricsFlow(),
+        metricsEnabled: currentAccount()?.metricsEnabled !== false,


StaberindeZA

r+. lgtm. ty.

vbudhram added the auto label Sep 23, 2026

vbudhram requested a review from a team September 23, 2026 21:00

vbudhram assigned LZoog Sep 23, 2026

Copilot AI balanced review requested due to automatic review settings September 23, 2026 21:00

Copilot started reviewing on behalf of vbudhram September 23, 2026 21:01 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread packages/fxa-settings/src/pages/SubscriptionsRedirect/index.tsx Outdated

vbudhram force-pushed the fxa-6661 branch from c53a38a to 29e33cb Compare September 23, 2026 21:19

vbudhram requested a balanced review from Copilot September 23, 2026 21:19

Copilot started reviewing on behalf of vbudhram September 23, 2026 21:19 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread packages/fxa-content-server/server/lib/routes/react-app/index.js Outdated

Comment on lines +133 to +136

routes: reactRoute.getRoutes([

'subscriptions',

'subscriptions/products/[\\w_]+',

]),

Comment thread packages/fxa-settings/src/pages/SubscriptionsRedirect/index.tsx Outdated

vbudhram force-pushed the fxa-6661 branch from 29e33cb to 9b222ef Compare September 23, 2026 21:39

vbudhram requested a balanced review from Copilot September 23, 2026 21:40

Copilot started reviewing on behalf of vbudhram September 23, 2026 21:40 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

Comment thread packages/fxa-settings/src/pages/SubscriptionsRedirect/index.tsx Outdated

Copilot AI review requested due to automatic review settings September 25, 2026 16:50

vbudhram force-pushed the fxa-6661 branch from 9b222ef to 431f9c8 Compare September 25, 2026 16:50

Copilot started reviewing on behalf of vbudhram September 25, 2026 16:51 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

vbudhram requested review from StaberindeZA and Copilot September 25, 2026 16:57

vbudhram force-pushed the fxa-6661 branch 2 times, most recently from 431f9c8 to a95cf7f Compare September 25, 2026 17:05

Copilot started reviewing on behalf of vbudhram September 25, 2026 17:06 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Comment thread packages/fxa-content-server/server/lib/routes/react-app/index.js

postVerifyOtherRoutes: {

featureFlagOn: showReactApp.postVerifyOtherRoutes,

routes: [],

routes: reactRoute.getRoutes(['subscriptions']),

StaberindeZA reviewed Sep 25, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 25, 2026 18:04

vbudhram force-pushed the fxa-6661 branch from a95cf7f to e875028 Compare September 25, 2026 18:04

Copilot started reviewing on behalf of vbudhram September 25, 2026 18:05 View session

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Comment thread packages/fxa-settings/src/pages/SubscriptionsRedirect/index.tsx

Comment on lines +39 to +42

getSubscriptionsRedirect({

paymentsNextUrl: config.servers.paymentsNext.url,

flow: getMetricsFlow(),

metricsEnabled: currentAccount()?.metricsEnabled !== false,

StaberindeZA approved these changes Sep 25, 2026

View reviewed changes

vbudhram merged commit 459e0c8 into main Sep 25, 2026
23 checks passed

vbudhram deleted the fxa-6661 branch September 25, 2026 18:28

Navigation Menu

feat(settings): serve /subscriptions redirects from React - #21295

feat(settings): serve /subscriptions redirects from React#21295
vbudhram merged 1 commit into
mainfrom
fxa-6661

vbudhram commented Sep 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

vbudhram commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

StaberindeZA Sep 25, 2026

Uh oh!

StaberindeZA Sep 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

StaberindeZA left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		path="/subscriptions"
		element={<SubscriptionsRedirect {...{ isSignedIn }} />}

Conversation

vbudhram commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Because

This pull request

Issue that this pull request solves

Checklist

How to review (Optional)

Screenshots (Optional)

Other information (Optional)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

vbudhram commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

StaberindeZA Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

StaberindeZA Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

StaberindeZA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vbudhram commented Sep 23, 2026 •

edited

Loading