chore(moq-native): bump to 0.17.1 to unblock moq-relay release#1755
Merged
Conversation
moq-relay's crates.io release fails resolving noq-proto: web-transport-iroh 0.5 pulls iroh 1.0.0-rc.0 (noq-proto =1.0.0-rc.0, exact) while the now-published noq-proto 1.0.0 satisfies noq's ^1.0.0-rc.0, so release-plz's dependencies_update cargo update conflicts with iroh's exact pin. main already bumped the workspace transports to web-transport-iroh 0.6 / web-transport-noq 0.2.0 (both on the stable iroh 1.0.0 / noq 1.0.0 line, which use noq-proto ^1.0.0 consistently), but moq-native 0.17.0 was already published with the old constraints and moq-relay depends on that. Bumping moq-native to 0.17.1 forces a fresh publish carrying the new constraints. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Release RSworkflow (run 27593759846) fails publishingmoq-relay 0.12.10to crates.io with anoq-protoversion conflict:web-transport-iroh 0.5→iroh 1.0.0-rc.0→noq-proto =1.0.0-rc.0(exact pin)web-transport-noq 0.1.1→noq 1.0.0-rc.0→noq-proto ^1.0.0-rc.0Now that
noq-proto 1.0.0is published, release-plz'sdependencies_update = truerunscargo update, which bumpsnoq-prototo1.0.0on thenoqpath and breaks iroh's exactrc.0pin.mainalready fixed the source by bumping the workspace transports toweb-transport-iroh 0.6/web-transport-noq 0.2.0, which ride the stableiroh 1.0.0/noq 1.0.0line and usenoq-proto ^1.0.0consistently. Butmoq-native 0.17.0was already published with the old constraints, andmoq-relaydepends on that published version, so the release keeps failing.This bumps
moq-native0.17.0→0.17.1(patch) so release-plz publishes a freshmoq-nativecarrying the corrected transport constraints, whichmoq-relaythen resolves against.Changes
rs/moq-native/Cargo.toml:version = "0.17.1"Cargo.lock: syncedVerification
cargo update --dry-runruns clean —noq-protoandirohboth resolve to1.0.0, no conflict.cargo check -p moq-relay --features noq(exercises both the defaultirohbackend andnoq) builds green againstmoq-native 0.17.1.🤖 Generated with Claude Code
(Written by Claude)