Repository navigation
make simulation child collections lists - #444
Merged
Merged
Conversation
Simulation.models, exchanges and solutiongroup were dicts whose keys silently overrode the children's own names. Make them lists like model packages, drop the dict child kind, accept a single child for any list field, and name unnamed simulation children after their class (gwf, gwf1, ims). Closes modflowpy#261 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wpbonelli
added a commit
to wpbonelli/pyphoenix-project
that referenced
this pull request
Oct 10, 2026
Simulation child collections are lists since modflowpy#444. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulation.models,exchangesandsolutiongroupwere dicts whose keys silently overrode the children's own names. Make them lists like modelpackages. This simplifies a bunch of thingsCloses #261