fix: align channel loss with sequence parallel labels - #9977
Merged
hjh0119 merged 1 commit intoSep 7, 2026
Conversation
taking-lying-flat
force-pushed
the
fix/issue-9973-channel-loss-sp
branch
from
August 24, 2026 12:04
cc5b50d to
3e06621
Compare
hjh0119
approved these changes
Sep 7, 2026
Collaborator
|
thanks, can you resolve the conflicts? |
Contributor
Author
just go home |
taking-lying-flat
force-pushed
the
fix/issue-9973-channel-loss-sp
branch
from
September 7, 2026 12:18
3e06621 to
a394f7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Fixes #9973.
When sequence parallelism is enabled,
per_token_loss_func_spgathers the per-token loss into the full-sequence layout, while channel-loss metrics still use labels from the local sequence shard. This causes anIndexErrorand applies the causal label shift twice.This PR:
GatherLoss;cu_seqlens;loss_scalegathering and padding removal, so channel metrics use the same scaled full-sequence loss.