[Train] Reduce padding-free embedding output memory - #9893
Open
taking-lying-flat wants to merge 1 commit into
Open
[Train] Reduce padding-free embedding output memory#9893taking-lying-flat wants to merge 1 commit into
taking-lying-flat wants to merge 1 commit into
Conversation
Signed-off-by: taking-lying-flat <1615405@qq.com>
taking-lying-flat
marked this pull request as ready for review
August 11, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cu_seq_lens_qand packedposition_ids, including the sequence-parallel path.Why
With
padding_free, the embedding path restored the full output to a dense[num_sequences, max_sequence_length, hidden_size]tensor before the outputnormalizer immediately selected only the last token of each sequence. For
multimodal batches with uneven sequence lengths, this creates a large temporary
allocation and retains its autograd graph until backward.
The embedding loss only needs one vector per sequence, so selecting those packed
positions directly avoids the re-padding allocation without changing the
resulting embeddings.
Fixes #9885.
Validation
pytest -q tests/models/test_patcher.pypre-commit run --files swift/model/patcher.py swift/trainers/mixin.py tests/models/test_patcher.py