fix(utils): avoid mutating caller ignore patterns - #10001
Open
gry67673905 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
safe_snapshot_download(..., download_model=False)appended weight-file exclusions to a caller-ownedignore_patternslist. Reusing that list for a subsequent full download could therefore still exclude.binand.safetensorsweights.Copy the list when adding metadata-only exclusions so the caller's patterns remain unchanged. The regression test covers a metadata-only download followed by a full download using the same list.
Experiment results
.venv/bin/python -m unittest tests.utils.test_hub_utils.venv/bin/pre-commit run --all-files