Repository navigation
[Backport release-0.5] Pin the model cache hydration image to one that distrusts eMudhra - #564
Closed
dennis-upbound wants to merge 1 commit into
Closed
dennis-upbound wants to merge 1 commit into
dennis-upbound wants to merge 1 commit into
Conversation
The hydration Job ran python:3.11-slim, whose pip 24.0 vendors a 2023 certifi that still trusts the compromised eMudhra intermediate CAs. The Job pip installs huggingface_hub from PyPI with the cache's HF_TOKEN in its environment, then writes the weights serving pods load. Anyone able to forge a certificate for PyPI on that path could run code in the Job, taking the token and tampering with the weights. This commit moves the Job to a python:3.13-slim pinned by digest, whose pip 26.2.2 distrusts the intermediates. Signed-off-by: Nic Cope <nicc@rk0n.org> (cherry picked from commit 3b8cba2) Signed-off-by: Dennis Ramdass <dennis@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Backport of #561 to
release-0.5, for v0.5.1. The backport bot couldn't cherry-pick it because the cache function's tests have diverged onmain. The only conflict was the expected hydration image intests/test_fn.py; I keptrelease-0.5's tests and updated that one line to the pinned image.I have:
RunRelying on CI for this branch.nix flake check(or./nix.sh flake check) and made sure it passes.git commit -s.