Repository navigation
Restore the Kimi-K2 recipe with the endpoint picker template - #560
Draft
dennis-upbound wants to merge 1 commit into
Draft
dennis-upbound wants to merge 1 commit into
dennis-upbound wants to merge 1 commit into
Conversation
24a5cdd removed the Kimi-K2 recipe because its ModelDeployment named the endpoint picker by image alone, which serving.endpointPicker no longer accepts. That left the docs home page with an empty Moonshot AI card. The recipe comes back with the picker written as a pod template. Its command line is the one the Qwen3-8B prefill/decode concept manifest uses, which ran live on GKE with the same picker image and plugins. Nothing else in the recipe changes. Verified without GPUs: the manifests validate against the generated models, the deployment composes through compose-model-replica's routing code, and the picker started on kind with this config, parsed its parameters and went Ready. The recipe still says its routing hasn't run live, as it did before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dennis Ramdass <dennis@upbound.io>
Collaborator
Author
|
Docs preview: https://modelplane-docs-pr-560.vercel.app (ready once the site's Content workflow finishes) |
2 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The docs home page shows an empty Moonshot AI card. #529 (24a5cdd) removed the Kimi-K2 recipe, the only Moonshot AI one, because its
ModelDeploymentnamed the endpoint picker by image alone, whichserving.endpointPickerno longer accepts.This is the alternative to #559, which removes the card instead. Merge one and close the other.
This PR brings the recipe back with the picker written as a pod template. The template is copied from
docs/manifests/concepts/model-deployment-disaggregated.yaml, which uses the same llm-d v0.9.0 picker image and plugins and ran live on GKE as a vLLM NIXL prefill/decode pair. Nothing else in the recipe changes: same engines, sidecar, picker config, H200 class and cluster.Verified without GPUs:
docs-manifestsvalidates all 145 manifests, including the five restored ones, anddocs-valehas no findings in the recipe page.compose-model-replica's routing code: a picker Deployment, its ConfigMap and the InferencePool, with theMODELPLANE_*pool, port and config variables set.maxPrefixBlocksToMatch: 256,lruCapacityPerServer: 31250), served on 9002 and 9003, and went Ready with no errors.Needs judgment: the routing still hasn't run live on H200s, and the recipe page says so, as it did before it was removed. A live run needs two p5en.48xlarge nodes with EFA. The earliest EC2 Capacity Block for those is Saturday, about $3K for 24 hours.
I have:
RunRan thenix flake check(or./nix.sh flake check) and made sure it passes.docs-manifestsanddocs-valechecks, the only ones these files reach; CI runs the rest.Added or updated tests covering any composition function changes.Docs only.git commit -s.🤖 Generated with Claude Code