Skip to content

Fix per-agent settings initialization order - #830

Closed
xdCloudy wants to merge 3 commits into
mindcraft-bots:developfrom
xdCloudy:fix/per-agent-settings-lifecycle
Closed

Fix per-agent settings initialization order#830
xdCloudy wants to merge 3 commits into
mindcraft-bots:developfrom
xdCloudy:fix/per-agent-settings-lifecycle

Conversation

@xdCloudy

Copy link
Copy Markdown

Summary

Fix configuration lifecycle issues caused by runtime modules reading settings before per-agent configuration has been populated.

Problem

Most agent code uses the child-process agent settings object, but some modules snapshot configuration at module-load time or import the root settings directly.

This can cause per-agent/UI settings to be ignored or replaced by stale global values. Minecraft version and block-placement settings are examples of values affected by this pattern.

Changes

  • Read runtime settings at the point where the agent is initialized instead of snapshotting them too early
  • Remove root-settings leakage from agent runtime code where applicable
  • Keep each agent tied to its own resolved settings
  • Preserve existing settings names and defaults

Why

Settings should be deterministic per agent. Module import timing should not decide which configuration an agent receives.

Compatibility

No configuration keys are renamed or removed.

Validation

Validated on the fork CI matrix with Node 20 and Node 22.

@Sweaterdog

Copy link
Copy Markdown
Contributor

quit spamming our repo with slop

@Sweaterdog Sweaterdog closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants