Fix per-agent settings initialization order - #830
Closed
xdCloudy wants to merge 3 commits into
Closed
Conversation
Contributor
|
quit spamming our repo with slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix configuration lifecycle issues caused by runtime modules reading settings before per-agent configuration has been populated.
Problem
Most agent code uses the child-process agent settings object, but some modules snapshot configuration at module-load time or import the root settings directly.
This can cause per-agent/UI settings to be ignored or replaced by stale global values. Minecraft version and block-placement settings are examples of values affected by this pattern.
Changes
Why
Settings should be deterministic per agent. Module import timing should not decide which configuration an agent receives.
Compatibility
No configuration keys are renamed or removed.
Validation
Validated on the fork CI matrix with Node 20 and Node 22.