Fix conversation timer and queue lifecycle handling - #820
Closed
xdCloudy wants to merge 1 commit into
Closed
Conversation
Contributor
|
quit spamming our repo with slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden conversation lifecycle management around timers, queued messages, and conversation teardown.
Problem
The conversation manager has several edge cases that can leave stale timers or inconsistent state behind:
These issues are most visible during rapid bot-to-bot conversation changes, interruptions, or shutdown/restart paths.
Changes
Why
Conversation state is shared by multiple async message paths. Small lifecycle mistakes can become intermittent runtime bugs that are difficult to reproduce.
Compatibility
No protocol, profile, or command changes are introduced.
Validation
Validated on the fork CI matrix with Node 20 and Node 22.