Harden ActionManager timeout and error-state handling - #819
Closed
xdCloudy wants to merge 3 commits into
Closed
Conversation
Contributor
|
quit spamming our repo with slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix several ActionManager lifecycle bugs that can leak state between actions and lose useful error information.
Problem
Action execution currently keeps timeout/interruption state on the manager instance. After a timeout, that state can affect later actions if it is not reset correctly.
The error path also converts an
Errorinto a string before attempting to record its stack trace, which causes the original stack information to be lost.These issues make failures harder to diagnose and can make subsequent actions behave as though an earlier timeout is still active.
Changes
Errorobject through failure handlingWhy
Action execution is a core runtime boundary. It should be deterministic per action and should preserve enough diagnostic context to understand failures.
This is particularly important for long-running autonomous agents where one transient timeout should not poison later actions.
Compatibility
No command syntax or agent profile changes are required.
Validation
Validated on the fork CI matrix with Node 20 and Node 22.