Correct SES sandbox lockdown initialization - #818
Closed
xdCloudy wants to merge 2 commits into
Closed
Conversation
Contributor
|
quit spamming our repo with slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix SES sandbox initialization so Mindcraft actually invokes SES
lockdown()instead of recursively calling its own wrapper.Problem
The current sandbox initialization helper shadows the global SES
lockdownfunction with a local function of the same name. When the helper attempts to initialize SES, it calls itself recursively. The guard flag prevents an infinite loop, but the real SES lockdown configuration is never applied.This means generated-code execution can continue without the hardening that the surrounding code expects to have enabled.
Changes
lockdownglobalThis.lockdown(...)Compartmentusage unchangedWhy
The generated-code path relies on SES as a security boundary. Failing to initialize lockdown correctly weakens that boundary and makes the runtime behavior differ from what the code intends.
Compatibility
No profile, command, model, or generated-code API changes are introduced. This only fixes sandbox initialization.
Validation
Validated on the fork CI matrix with Node 20 and Node 22, including dependency installation and JavaScript syntax checks.