Skip to content

fix: respect disabled nested project discovery - #1913

Open
wenyt (wenytang-ms) wants to merge 3 commits into
developfrom
fix/respect-nested-projects-disabled
Open

wenyt (wenytang-ms) wants to merge 3 commits into
developfrom
fix/respect-nested-projects-disabled

Conversation

@wenytang-ms

Copy link
Copy Markdown
Contributor

Summary

  • respect gradle.nestedProjects: false for non-Gradle workspace roots
  • retain standalone nested build discovery when explicitly enabled
  • update unit and integration coverage

Fixes #1905

Copilot-Session: 85a835d8-9922-4224-8646-a94232262092
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

The updated integration test can become a false-positive by asserting “no tasks” without waiting for async task discovery to settle.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Updates nested Gradle project discovery so it only runs when explicitly enabled via gradle.nestedProjects: true, preventing unintended workspace-wide scans (notably in Flutter-shaped roots) and aligning behavior with the setting’s disabled state.

Changes:

  • Remove implicit nested-project discovery when the workspace root is not a Gradle project unless nestedProjects is explicitly true.
  • Update unit tests to assert no nested scan occurs when nestedProjects is disabled.
  • Adjust integration coverage for the disabled setting scenario.
File summaries
File Description
extension/src/stores/RootProjectsStore.ts Stops auto-enabling nested discovery for non-Gradle roots; discovery now requires explicit nestedProjects: true.
extension/src/test/unit/RootProjectsStore.test.ts Updates unit expectations to ensure no findFiles() scan happens when disabled.
extension/src/test/integration/nested-projects/extension.test.ts Updates integration scenario for disabled discovery to expect no Gradle tasks.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread extension/src/test/integration/nested-projects/extension.test.ts
Copilot-Session: 85a835d8-9922-4224-8646-a94232262092

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The behavior change is narrowly scoped to explicit configuration, and the updated unit/integration tests directly validate the new discovery semantics.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested project discovery (auto-enabled for Flutter-shaped roots) follows symlinks out of the workspace into ~/.pub-cache

2 participants