Support nested closure completions - #1337
Open
Gayan Perera (gayanper) wants to merge 1 commit into
Open
Gayan Perera (gayanper) wants to merge 1 commit into
Gayan Perera (gayanper) wants to merge 1 commit into
Conversation
Gayan Perera (gayanper)
requested review from
Sheng Chen (jdneo) and
Jinbo Wang (testforstephen)
as code owners
May 18, 2023 17:54
Contributor
Author
|
Sheng Chen (@jdneo) Jinbo Wang (@testforstephen) Let me know what you think |
Gayan Perera (gayanper)
force-pushed
the
support_action_closures
branch
from
May 18, 2023 18:59
d40b781 to
94db159
Compare
Gayan Perera (gayanper)
force-pushed
the
support_action_closures
branch
from
May 19, 2023 18:09
94db159 to
5de9994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the plugin only sees the root level extensions and their methods, But if such method supports closure which contains a type, completions are not supported for such closures.
This change tries to find such methods and expand closure collection based on those closure types which could be for example a extension.
Good example of a code snippet to tryout this change is spotless plugin configuration as below
if you try to invoke completions inside json closure, you don't get any and if you try to do the same inside java you endup with config values for standard java plugin.
When this change is applied, the correct configuration values are shown from the relevant spotless extension.
Note: method chaining is still not working which needs to be separately add support.