Restore navigation menu accessibility announcement - #924
Merged
Conversation
Restore the AccessibilityInfo import removed with the hidden skip control cleanup and add coverage that invokes the navigation menu handler. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 18f319cb-b4f4-4b6b-ae4d-b8f429333447
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues remain, and the focused regression coverage addresses the fix.
Pull request overview
Restores the missing accessibility import and adds regression coverage for navigation-menu announcements.
Changes:
- Re-adds
AccessibilityInfotoScreenWrapper. - Tests the expansion announcement.
File summaries
| File | Summary |
|---|---|
src/components/ScreenWrapper.tsx |
Restores the required accessibility API import. |
__tests__/ScreenWrapper.test.tsx |
Adds announcement regression coverage. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
anuagragith
requested review from
Andrew Coates (acoates-ms) and
Vladimir Morozov (vmoroz)
September 10, 2026 23:08
Vladimir Morozov (vmoroz)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gallery PR #921 removed the
AccessibilityInfoimport fromScreenWrapper.tsxwhile leaving two references toAccessibilityInfo.announceForAccessibility.As a result, opening the navigation drawer throws:
Property 'AccessibilityInfo' doesn't existThis change:
AccessibilityInfoimport.Validation
ScreenWrapperregression test passed.AccessibilityInfo,ReferenceError, orTypeErrorerrors occurred.Microsoft Reviewers: Open in CodeFlow