[TESTING] GNR TDX machines - #4138
Open
Trevor Jones (tjones60) wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OpenVMM’s GitHub Actions runner selection for the Windows x64 Intel TDX VMM test jobs to target new “GNR” self-hosted baremetal machines.
Changes:
- Updated the Flowey-defined self-hosted runner label set for the Windows x64 Intel TDX baremetal pool to use
GNR. - Propagated the corresponding
runs-onlabel change into the generated GitHub Actions workflows (PR / PR release / CI).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| flowey/flowey_hvlite/src/pipelines_shared/gh_pools.rs | Changes the canonical Flowey runner label set used to select the Windows x64 Intel TDX baremetal pool. |
| .github/workflows/openvmm-pr.yaml | Updates the workflow job’s runs-on labels to match the new pool label. |
| .github/workflows/openvmm-pr-release.yaml | Updates the release PR workflow job’s runs-on labels to match the new pool label. |
| .github/workflows/openvmm-ci.yaml | Updates the CI workflow job’s runs-on labels to match the new pool label. |
Comment on lines
88
to
92
| "self-hosted".to_string(), | ||
| "Windows".to_string(), | ||
| "X64".to_string(), | ||
| "TDX".to_string(), | ||
| "GNR".to_string(), | ||
| "Baremetal".to_string(), |
Comment on lines
4400
to
4404
| - self-hosted | ||
| - Windows | ||
| - X64 | ||
| - TDX | ||
| - GNR | ||
| - Baremetal |
Comment on lines
4222
to
4226
| - self-hosted | ||
| - Windows | ||
| - X64 | ||
| - TDX | ||
| - GNR | ||
| - Baremetal |
Comment on lines
3995
to
3999
| - self-hosted | ||
| - Windows | ||
| - X64 | ||
| - TDX | ||
| - GNR | ||
| - Baremetal |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
flowey/flowey_hvlite/src/pipelines_shared/gh_pools.rs:93
windows_tdx_self_hosted_baremetal()now returns a runner label set that includes "GNR" (and no longer includes a "TDX" label), but the function name and downstream usage still describe this pool as "tdx" (e.g., it’s used for the "x64-windows-intel-tdx" job). This mismatch makes it hard to reason about what hardware/capabilities the pool guarantees and risks future misrouting.
Consider either (a) keeping the "TDX" label and adding "GNR" as an additional label if you want “TDX-on-GNR” specificity, or (b) renaming the function/call sites/job labels to reflect that this is a GNR-specific pool (while keeping the CVM/TDX semantics in the test filter names).
"Windows".to_string(),
"X64".to_string(),
"GNR".to_string(),
"Baremetal".to_string(),
])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test new GNR TDX blades