1.8: nvme: Quiet some noisy logs during vmm tests (#4070) - #4124
Merged
Steven Malis (smalis-msft) merged 1 commit intoAug 4, 2026
Merged
Conversation
These tracing statements take up a lot of space in nvme tests runs (example: https://openvmm.dev/test-results/#/runs/30395677982/x64-windows-intel-mi-secure-vmm-tests-logs/multiarch__openvmm_openhcl_uefi_x64_windows_datacenter_core_2022_x64_uefi_force_dma_bounce?log=831). Lower them to trace level. (cherry picked from commit 89a26b1)
Steven Malis (smalis-msft)
added
the
release_1.8.2607
Contributor
There was a problem hiding this comment.
Pull request overview
This backport reduces NVMe admin-path log verbosity so vmm test runs aren’t flooded with per-command / inactive-namespace messages.
Changes:
- Lowered the per-admin-command
"command"log fromdebugtotracein the NVMe admin worker. - Lowered
"inactive namespace id"logs fromdebugtotracein both the NVMe implementation and the NVMe test worker.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vm/devices/storage/nvme/src/workers/admin.rs | Downgrades noisy admin command and inactive-namespace logs to trace to reduce test log volume. |
| vm/devices/storage/nvme_test/src/workers/admin.rs | Downgrades inactive-namespace logs to trace to keep nvme_test output quieter. |
Steven Malis (smalis-msft)
enabled auto-merge (squash)
July 31, 2026 17:20
Matt LaFayette (Kurjanowicz) (mattkur)
approved these changes
Aug 4, 2026
Steven Malis (smalis-msft)
merged commit Aug 4, 2026
5dc6de9
into
microsoft:release/1.8.2607
154 of 158 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4070 to
release/1.8.2607.The cherry-pick of 89a26b1 applied cleanly onto
release/1.8.2607with no conflicts and no manual edits.Original PR: #4070
This backport PR was created by an AI agent (GitHub Copilot) on behalf of @smalis-msft.