update qnn gpu - #621
Open
xieofxie wants to merge 16 commits into
Open
update qnn gpu#621xieofxie wants to merge 16 commits into
xieofxie wants to merge 16 commits into
Conversation
Co-authored-by: hualxie <hualxie@microsoft.com>
xieofxie
commented
Sep 17, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Moderate findings remain in WebGPU comparison ignore patterns for nested and removed s fields.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates AITK QNN GPU and WebGPU recipes with Olive support, revised conversion passes, and model-specific comparison settings.
Changes:
- Adds Olive runtime dependencies and feature flags.
- Updates QNN GPU conversion and context settings.
- Adds WebGPU references and improves sanitizer diagnostics.
File summaries
| File | Summary |
|---|---|
Qwen-Qwen2.5-1.5B-Instruct/aitk/qwen2_5_webgpu.json.config |
Moderate (2 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
Qwen-Qwen2.5-1.5B-Instruct/aitk/qwen2_5_qnn_gpu_config.json.config |
Adds Olive runtime feature requirements. |
Qwen-Qwen2.5-1.5B-Instruct/aitk/qwen2_5_qnn_gpu_config.json |
Updates QNN conversion passes. |
Qwen-Qwen2.5-1.5B-Instruct/aitk/info.yml |
Moderate (3 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
microsoft-Phi-3.5-mini-instruct/aitk/phi3_5_webgpu.json.config |
Moderate (2 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
microsoft-Phi-3.5-mini-instruct/aitk/phi3_5_qnn_gpu_config.json.config |
Adds Olive runtime feature requirements. |
microsoft-Phi-3.5-mini-instruct/aitk/phi3_5_qnn_gpu_config.json |
Updates QNN conversion passes. |
microsoft-Phi-3.5-mini-instruct/aitk/info.yml |
Moderate (3 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
meta-llama-Llama-3.2-1B-Instruct/aitk/llama3_2_webgpu.json.config |
Moderate (2 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
meta-llama-Llama-3.2-1B-Instruct/aitk/llama3_2_qnn_gpu_config.json.config |
Adds Olive runtime feature requirements. |
meta-llama-Llama-3.2-1B-Instruct/aitk/llama3_2_qnn_gpu_config.json |
Updates QNN conversion passes. |
meta-llama-Llama-3.2-1B-Instruct/aitk/info.yml |
Moderate (3 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
meta-llama-Llama-3.1-8B-Instruct/aitk/llama3_1_webgpu.json.config |
Moderate (2 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
meta-llama-Llama-3.1-8B-Instruct/aitk/llama3_1_qnn_gpu.json.config |
Adds Olive runtime feature requirements. |
meta-llama-Llama-3.1-8B-Instruct/aitk/llama3_1_qnn_gpu.json |
Updates QNN conversion passes. |
meta-llama-Llama-3.1-8B-Instruct/aitk/info.yml |
Moderate (3 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
deepseek-ai-DeepSeek-R1-Distill-Qwen-1.5B/aitk/info.yml |
Moderate (3 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
deepseek-ai-DeepSeek-R1-Distill-Qwen-1.5B/aitk/deepseek_webgpu.json.config |
Moderate (2 votes): The s ignore pattern does not match nested or removed paths; use a subtree prefix and ignoreRemoved. |
.aitk/scripts/sanitize/model_parameter.py |
Improves Olive reference path diagnostics. |
.aitk/requirements/General/CUDA_py3.12.9-olive.txt |
Adds pinned Olive dependencies. |
.aitk/configs/checks.json |
Updates validation counts. |
Review details
- Files reviewed: 26/26 changed files
- Comments generated: 10
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+53
to
+54
| ignoreChanged: | ||
| - ^root\['s'\]$ |
Comment on lines
+7
to
+9
| "ignoreChanged": [ | ||
| "^root\\['s'\\]$" | ||
| ] |
Comment on lines
+50
to
+51
| ignoreChanged: | ||
| - ^root\['s'\]$ |
Comment on lines
+7
to
+9
| "ignoreChanged": [ | ||
| "^root\\['s'\\]$" | ||
| ] |
Comment on lines
+7
to
+9
| "ignoreChanged": [ | ||
| "^root\\['s'\\]$" | ||
| ] |
Comment on lines
+53
to
+54
| ignoreChanged: | ||
| - ^root\['s'\]$ |
Comment on lines
+7
to
+9
| "ignoreChanged": [ | ||
| "^root\\['s'\\]$" | ||
| ] |
added 12 commits
September 17, 2026 16:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.