Repository navigation
Fix interrupted download recovery: check executable, not directory - #135
Merged
LakshyAAAgrawalP merged 1 commit intoApr 10, 2026
Conversation
If a language server binary download is interrupted, the target directory exists but the executable does not. On next invocation the directory check passes, the download is skipped, and the assertion on the executable fails. Fix by checking for the executable/binary instead of the directory. Also use exist_ok=True on makedirs so a partial directory from a previous attempt doesn't cause an error. Affected servers: rust-analyzer, dart, clangd, omnisharp, typescript. Kotlin and solargraph already checked correctly. Fixes microsoft#131
LakshyAAAgrawalP
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a language server binary download is interrupted (crash, kill, network timeout), the target directory exists but the executable does not. On next invocation, the directory-existence check passes, the download is skipped, and an
AssertionErroris raised because the executable is missing.Fix: check for the executable instead of the directory, and use
exist_ok=Trueonmakedirsso a leftover directory from a previous attempt doesn't cause errors.Affected servers:
rustanalyzer_ls_dir→rustanalyzer_executable_pathdart_ls_dir→dart_executable_pathclangd_ls_dir→clangd_executable_pathomnisharp_ls_dir→omnisharp_executable_path,razor_omnisharp_ls_dir→razor_omnisharp_dll_pathtsserver_ls_dir→tsserver_executable_pathNot affected (already correct): kotlin, solargraph, jedi.
Fixes #131