Fix Windows exception callback argument passing - #1256
Merged
Weiteng Chen (CvvT) merged 2 commits intoSep 2, 2026
Conversation
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
Weiteng Chen (CvvT)
marked this pull request as ready for review
September 2, 2026 01:01
Weiteng Chen (CvvT)
deleted the
weiteng/windows-exception-callback-argument-fix
branch
September 2, 2026 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code assumed that
rspis restored tohost_spand then read thread context via*rsptorcx, butrspis actually assigned tohost_sp - EXCEPTION_RECORD. This PR fixes it by directly assigning*host_sptorcx.