Cherry pick #1107 Migrate in-memory file system to new backend - #1255
Merged
Jay Bosamiya (Microsoft) (jaybosamiya-ms) merged 3 commits intoSep 2, 2026
Conversation
This PR switches our in-memory filesystem to the new core file system design (see #887). Concretely, it adds a `InMem` backend, migrates all old usage of `in_mem::FileSystem` to a resolver-backed one to use the new `InMem` backend, and then removes the old `in_mem::FileSystem`. It also revamps the in-mem backend initialization design, moving away from the ugly "temporarily change user and do operations" to an actual controlled initialization, which reduces the chances of footguns, and also makes future improvements easier :)
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
marked this pull request as ready for review
September 2, 2026 00:54
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
enabled auto-merge
September 2, 2026 00:54
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/cherrypick/migrate-in-memory-filesystem
branch
from
September 2, 2026 01:00
e4ef17c to
15c66af
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
force-pushed
the
jayb/cherrypick/migrate-in-memory-filesystem
branch
from
September 2, 2026 01:03
15c66af to
a871fb5
Compare
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
removed this pull request from the merge queue due to a manual request
Sep 2, 2026
|
🤖 SemverChecks 🤖 Click for details |
Jay Bosamiya (Microsoft) (jaybosamiya-ms)
deleted the
jayb/cherrypick/migrate-in-memory-filesystem
branch
September 2, 2026 01:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this cherry-pick onto ulitebox is not clean, because ulitebox makes assumptions (due to #894) on how permission checks on directories should behave. Specifically, the Windows shim forces an incorrect implementation within the core, that would force incorrect behavior at the Linux shim. A proper fix would need a broader set of changes, so will need to be done separately. For now, this is documented by a comment and any time this is triggered at runtime, a debug log is printed.