Skip to content

feat(dpkg): add dpkg to base rpm repo#17812

Merged
reubeno merged 1 commit into
4.0from
tobiasb-ms/dpkg-rpm-base
Jun 26, 2026
Merged

feat(dpkg): add dpkg to base rpm repo#17812
reubeno merged 1 commit into
4.0from
tobiasb-ms/dpkg-rpm-base

Conversation

@tobiasb-ms

Copy link
Copy Markdown
Contributor

In commit 8d904bb we added debootstrap, putting it in the base rpm repo. But we missed dpkg, which is a dependency of debootstrap. This change adds dpkg to the base rpm repo.

Built locally and installed via local yum repo. Both dpkg and debootsrap install correctly.

Copilot AI review requested due to automatic review settings June 25, 2026 22:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds dpkg to the base-packages component group in base/comps/components-publish-channels.toml. By default all components publish to the rpm-sdk channels; membership in the base-packages group overrides this so the package (and its runtime closure) publishes to the rpm-base channels instead. This is a follow-up to commit 8d904bb which added debootstrap to the base repo but omitted dpkg, a runtime dependency of debootstrap, so debootstrap could not be satisfied from rpm-base alone.

Changes:

  • Add "dpkg" to the component-groups.base-packages list so it is published to the rpm-base channel rather than the default rpm-sdk channel.

Verification notes:

  • dpkg is already a defined component (base/comps/components.toml:351), so no new component definition is required.
  • The insertion preserves the required alphabetical ordering (dpdk < dpkg < dracut), matching the convention noted in the file header comment.
  • This is a publish-channel-only change; it does not alter dpkg's rendered spec or lock file, so no render/update refresh is needed.
  • Consistent with how debootstrap itself was added to this group (line 220).

@tobiasb-ms tobiasb-ms marked this pull request as ready for review June 25, 2026 23:59
@tobiasb-ms tobiasb-ms requested a review from a team as a code owner June 25, 2026 23:59
@reubeno reubeno merged commit 09433ca into 4.0 Jun 26, 2026
12 checks passed
@reubeno reubeno deleted the tobiasb-ms/dpkg-rpm-base branch June 26, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants