Skip to content

Don't fail the installation if DeprovisionMsix() fails - #41453

Open
Blue (OneBlue) wants to merge 2 commits into
masterfrom
user/oneblue/fix-msi-deprovision
Open

Don't fail the installation if DeprovisionMsix() fails#41453
Blue (OneBlue) wants to merge 2 commits into
masterfrom
user/oneblue/fix-msi-deprovision

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This change solves a regression introduced in #41415 which causes WaitForDeploymentOperation() to throw on error instead of just returning the error to the caller, which causes installation failures on builds that don't support direct MSI execution.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI lite review requested due to automatic review settings August 26, 2026 18:55
@OneBlue
Blue (OneBlue) requested a review from a team as a code owner August 26, 2026 18:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts MSI custom-action handling in wslinstall.dll so that failures from DeprovisionMsix() don’t inadvertently abort installation, restoring the intended behavior for deployments where MSIX deprovisioning can fail but should be treated as non-fatal.

Changes:

  • Stop WaitForDeploymentOperation() from throwing when the async operation reports AsyncStatus::Error, allowing callers to inspect DeploymentResult instead.
  • Move source-location context into ThrowIfOperationError()’s THROW_IF_FAILED_MSG(...) so error reporting still includes call-site details when the caller chooses to treat the result as fatal.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/windows/wslinstall/DllMain.cpp Outdated
Copilot AI review requested due to automatic review settings August 26, 2026 19:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants