Don't fail the installation if DeprovisionMsix() fails - #41453
Open
Blue (OneBlue) wants to merge 2 commits into
Open
Don't fail the installation if DeprovisionMsix() fails#41453Blue (OneBlue) wants to merge 2 commits into
Blue (OneBlue) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts MSI custom-action handling in wslinstall.dll so that failures from DeprovisionMsix() don’t inadvertently abort installation, restoring the intended behavior for deployments where MSIX deprovisioning can fail but should be treated as non-fatal.
Changes:
- Stop
WaitForDeploymentOperation()from throwing when the async operation reportsAsyncStatus::Error, allowing callers to inspectDeploymentResultinstead. - Move source-location context into
ThrowIfOperationError()’sTHROW_IF_FAILED_MSG(...)so error reporting still includes call-site details when the caller chooses to treat the result as fatal.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves a regression introduced in #41415 which causes
WaitForDeploymentOperation()to throw on error instead of just returning the error to the caller, which causes installation failures on builds that don't support direct MSI execution.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed