fix(static): stop static handler after validation failures - #157
Open
codxbrexx wants to merge 3 commits into
Open
fix(static): stop static handler after validation failures#157codxbrexx wants to merge 3 commits into
codxbrexx wants to merge 3 commits into
Conversation
Stop the static controller after validation failures so it does not continue into sendFile after entering the error path. Also fixes the undeployed-app error message to include the real application suffix and adds route-level regression tests.
Member
|
Can you merge master into this so we validate it works? |
Contributor
Author
merged latest master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a control-flow bug in
src/controller/static.ts.The static handler already forwarded validation failures with
next(...), but it did not stop execution. Because of that, the request could still continue tosendFile(...)after entering the error path.This change makes the handler return immediately on validation failure and fixes the undeployed-app message so it shows the real application suffix.
Problem statement
The static route should do one of two things:
Before the fix, it could do both paths in the same request because the error branches were missing
return.What changed
Tests Screensort
Type of change
Checklist
Release notes
Fixed the static file route so failed validation exits immediately instead of falling through to
sendFile(...).