Repository navigation
refactor(bundler): separate the client queries from the client and server targets, remove the SWC clientBrowserslistQueries param (AI-assisted) - #12778
Merged
Conversation
…es, remove the SWC `clientBrowserslistQueries` param (AI-assisted)
- getTargets({isServer, bundlerName}) returns getServerTargets() or
getClientTargets()
- getBrowserslistQueries() is renamed getClientTargets()
- getServerBrowserslistQueries() is renamed getServerTargets() and moves
next to it, to avoid a circular import with swc.ts
- getSwcLoaderOptions() reads the targets itself: the
clientBrowserslistQueries param was a leftover from when the SWC options
lived in @docusaurus/faster (#12604)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
the
pr: maintenance
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 6 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names a refactor in the bundler package that separates client queries from client and server targets and removes the SWC clientBrowserslistQueries parameter. The raw summary confirms these c… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names a refactor in the bundler package that separates client queries from client and server targets and removes the SWC clientBrowserslistQueries parameter. The raw summary confirms these changes: getBrowserslistQueries is renamed to getClientQueries, the new getServerTargets function is added, and getSwcLoaderOptions drops clientBrowserslistQueries. The title is specific and matches the main change. Its length (145 characters) is long, and the "(AI-assisted)" suffix is noise, but neither makes the title unrelated or vague.
-
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
…s (AI-assisted) - getClientQueries() returns the Browserslist queries - getClientTargets() returns the browsers they match - SWC keeps receiving the client queries: Rspack resolves them with its own Browserslist data - getTargets() moves to the cache eviction PR, its only user Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
changed the title
getTargets() for the client and server bundles, remove the SWC clientBrowserslistQueries param (AI-assisted)clientBrowserslistQueries param (AI-assisted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
getSwcLoaderOptions()received the client Browserslist queries as aclientBrowserslistQueriesparam, but computed the server targets itself. The param is a leftover from when the SWC options lived in@docusaurus/faster, which didn't own the Browserslist config (#12604). They now live in@docusaurus/bundlernext to it.This refactor also separates the client queries from the targets, for the stacked cache eviction PR #12774:
getBrowserslistQueries()is renamedgetClientQueries(), including its@docusaurus/bundlerexport added by fix(core): evict the bundler persistent cache when the Browserslist queries change (AI-assisted) #12727, which no release contains yet.getClientTargets(): the browsers that the client queries match. The Webpack Lightning CSS minimizer uses it.getServerBrowserslistQueries()is renamedgetServerTargets(): these targets aren't Browserslist queries, and Browserslist doesn't know all the Node.js patch releases they can contain. It moves fromswc.tstobrowserslist.tswith its helpers.getSwcLoaderOptions()reads the targets itself, without the param. SWC keeps receiving the client queries, not the resolved targets: Rspack resolves them with its own Browserslist data. Browserslist caches its config lookups, so reading the client queries for each loader costs nothing.No behavior change.
Test Plan
Existing tests. The SWC and Lightning CSS options are the same as before:
['baseline widely available']for the client and['node 26.0.0']for the server (Rspack).Test links
Deploy preview: https://deploy-preview-12778--docusaurus-2.netlify.app/
Related issues/PRs
future.faster.lightningCssMinimizer(AI-assisted) #12604🤖 Generated with Claude Code
Summary by CodeRabbit