middleware: add request context to Observer callback - #267
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 94.98% 94.84% -0.14%
==========================================
Files 9 9
Lines 2032 2036 +4
==========================================
+ Hits 1930 1931 +1
- Misses 59 62 +3
Partials 43 43
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to belatedly dogfood this Observer mechanism over in mccutchen/httpbingo.org#14, I realized that we should pass the request context to the observer callback so that tracing frameworks can propagate trace/span IDs and other custom per-request metadata.
Unfortunately, this is a breaking change, but I think it's worth the breakage to better support request tracing for those custom deployments that want an easy way to do it.