Repository navigation
fix(scorecard): reject gate entries with neither result nor reason - #2
Merged
Merged
Conversation
A gate whose RESULT object was stored flat on the entry, instead of under
.result, scored as a full-credit "proxy [A]" row. A failing fan-out recorded
as {ok, pass: false, code: 'MISSED', tier: 'A'} produced 100 / HIGH. Found on
the first real run: three gates recorded flat printed 0 / NOT SHIPPABLE on the
hard rows and "proxy [A]" on the weighted ones, and neither said why.
The scorecard now checks every gate entry except QA before scoring. An entry
needs a reason (proxy or n/a) or a result object; anything else is
BAD_RECORD, exit 2, with the gates named. The input that used to pass wrongly
is the flat failing fan-out above; the new test fails on it before this
change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A gate whose RESULT object was stored flat on the entry, instead of under
.result, scored as a full-credit "proxy [A]" row. A failing fan-out recorded
as {ok, pass: false, code: 'MISSED', tier: 'A'} produced 100 / HIGH. Found on
the first real run: three gates recorded flat printed 0 / NOT SHIPPABLE on the
hard rows and "proxy [A]" on the weighted ones, and neither said why.
The scorecard now checks every gate entry except QA before scoring. An entry
needs a reason (proxy or n/a) or a result object; anything else is
BAD_RECORD, exit 2, with the gates named. The input that used to pass wrongly
is the flat failing fan-out above; the new test fails on it before this
change.