Repository navigation
msgconv/from-signal: update size of converted voice messages - #738
Open
iFixRobots wants to merge 1 commit into
Open
iFixRobots wants to merge 1 commit into
iFixRobots wants to merge 1 commit into
Conversation
Contributor
|
No issues found.
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuploaded voice messages set
info.sizefrom the original attachment pointer, so after the ogg/opus conversion the event still reported the size of the AAC file. I now stat the converted file and use its size, like gmessages does.Before / after
info.sizevs downloaded mxcaudio/oggaudio/oggLinear: https://linear.app/beeper/issue/PLAT-40525
Tag
@indentto continue the conversation here.