Skip to content

msgconv/from-signal: update size of converted voice messages - #738

Open
iFixRobots wants to merge 1 commit into
mainfrom
iFixRobots/signal-voice-size
Open

iFixRobots wants to merge 1 commit into
mainfrom
iFixRobots/signal-voice-size

Conversation

@iFixRobots

Copy link
Copy Markdown
Contributor

Reuploaded voice messages set info.size from the original attachment pointer, so after the ogg/opus conversion the event still reported the size of the AAC file. I now stat the converted file and use its size, like gmessages does.

Before / after

Case Base Head
Voice note, info.size vs downloaded mxc 18973 vs 34689 bytes 25956 vs 25956 bytes
Mimetype audio/ogg audio/ogg

Linear: https://linear.app/beeper/issue/PLAT-40525

View in Indent
Tag @indent to continue the conversation here.

@indent

indent Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Issues

No issues found.

CI Checks

All required CI checks passed on 5e21033.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues found; size fix is correct.
Full results

Indent Review Agent

  • Summary: No issues found; size fix is correct.
  • Last ran on commit: 5e210338
  • Latest result
    {
      "summary": "No issues found; size fix is correct.",
      "findings": []
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants