Repository navigation
messagix/bloks: return 5 from TypeOf for actions without a value - #580
Merged
Merged
Conversation
Contributor
|
No issues found.
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
highesttt
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On native Instagram login, after the reCAPTCHA,
recaptcha_submitcan answer with a native dialog such as "The password you entered is incorrect." We open the dialog, but in the same step the login fails with:so users get the generic "couldn't complete this sign-in step" error and never see what Instagram said.
The webview callback passes the result of the
recaptcha_submitaction to its success callback, which checks(bk.action.mins.TypeOf result)against 7 to see whether it got a map. Here the action isig.action.cdsdialog.OpenDialog, which returnsBloksNothing, andgetBloksTypeerrors on it. This returns 5 for it, the tag native code uses for values without a specific type, so the callback skips its map branch and the dialog becomes the normal dialog login step.Verified by replaying two production
recaptchapage +recaptcha_submitresponses throughBrowser.DoLoginStepwith a fake token:submitting reCAPTCHA token: unexpected bloks typecheck for *bloks.BloksIllegalValuefi.mau.meta.instagram.caa.dialogstep with "The password you entered is incorrect." and an OK optionTag
@indentto continue the conversation here.