Skip to content

messagix/bloks: return 5 from TypeOf for actions without a value - #580

Merged
highesttt merged 1 commit into
mainfrom
iFixRobots/bloks-typeof-nothing
Nov 12, 2026
Merged

highesttt merged 1 commit into
mainfrom
iFixRobots/bloks-typeof-nothing

Conversation

@iFixRobots

Copy link
Copy Markdown
Contributor

On native Instagram login, after the reCAPTCHA, recaptcha_submit can answer with a native dialog such as "The password you entered is incorrect." We open the dialog, but in the same step the login fails with:

submitting reCAPTCHA token: unexpected bloks typecheck for *bloks.BloksIllegalValue

so users get the generic "couldn't complete this sign-in step" error and never see what Instagram said.

The webview callback passes the result of the recaptcha_submit action to its success callback, which checks (bk.action.mins.TypeOf result) against 7 to see whether it got a map. Here the action is ig.action.cdsdialog.OpenDialog, which returns BloksNothing, and getBloksType errors on it. This returns 5 for it, the tag native code uses for values without a specific type, so the callback skips its map branch and the dialog becomes the normal dialog login step.

Verified by replaying two production recaptcha page + recaptcha_submit responses through Browser.DoLoginStep with a fake token:

  • main: submitting reCAPTCHA token: unexpected bloks typecheck for *bloks.BloksIllegalValue
  • this branch: fi.mau.meta.instagram.caa.dialog step with "The password you entered is incorrect." and an OK option

View in Indent
Tag @indent to continue the conversation here.

@indent

indent Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Issues

No issues found.

CI Checks

All required CI checks passed on 42ae68c.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues found in the TypeOf change.
Full results

Indent Review Agent

  • Summary: No issues found in the TypeOf change.
  • Last ran on commit: 42ae68c9
  • Latest result
    {
      "summary": "No issues found in the TypeOf change.",
      "findings": []
    }

@iFixRobots
iFixRobots requested a review from highesttt November 12, 2026 12:21
@highesttt
highesttt merged commit 74e2a99 into main Nov 12, 2026
5 checks passed
@highesttt
highesttt deleted the iFixRobots/bloks-typeof-nothing branch November 12, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants